gibbonjoyeux / VCV-Biset

VCV Rack Biset modules library
GNU General Public License v3.0
37 stars 3 forks source link

Consider changing your license so Biset can contribute to Cardinal? #27

Open taji opened 3 months ago

taji commented 3 months ago

Hi, big fan of the blank module. Very useful. But I'm trying to stay in Cardinal: https://github.com/DISTRHO/Cardinal

I know it's a big ask, you'll need to change your license, then integrate into Cardinal (as per here):

https://github.com/DISTRHO/Cardinal/discussions/28

But it can't hurt to ask. :-)

gibbonjoyeux commented 3 months ago

Hello ! Thanks for your message :) That would be a cool idea indeed !

About the license, what license would it need, as the project is already open-source (MIT) ?

For the integration, it does not look too difficult but that would probably require a bit of time to be able to build Cardinal and then add the whole plugin. I could do that, I don't have much time at the moment but if ever I find the time, I'll try to build it and see :)

gibbonjoyeux commented 3 months ago

Just found out that Cardinal can't be built directly on Windows (needs cross compiling from Linux).

I could update blindly without trying to build though, it's still an option but that could also be quite a pain for Cardinal developers

taji commented 3 months ago

No worries, I have a linux machine and may be able to help with getting it working on Linux. But alas, very little time. If I do have time to assist, where would you recommend I start with getting a development environment up and running?

Or am I misunderstanding your concern?

Thanks :-)

gibbonjoyeux commented 2 months ago

Have you ever tried to compile Cardinal ? Once this step done, the "How to" you sent me looks quite simple. But I realized that I have access to a Linux computer from time to time, I could try this weekend.

So if you already achieved to compile Cardinal for other projects, this would probably be faster but otherwise I'll try at the end of the week :)

taji commented 2 months ago

Hi :-)

No chance right now to download Cardinal code. It will be a while (weeks/months) before I will be able to jump into it.

Thanks again for considering Cardinal. So far I've really enjoyed using it in Linux.

On Wed, Apr 3, 2024 at 4:19 AM gibbonjoyeux @.***> wrote:

Have you ever tried to compile Cardinal ? Once this step done, the "How to" you sent me looks quite simple. But I realized that I have access to a Linux computer from time to time, I could try this weekend.

So if you already achieved to compile Cardinal for other projects, this would probably be faster but otherwise I'll try at the end of the week :)

— Reply to this email directly, view it on GitHub https://github.com/gibbonjoyeux/VCV-Biset/issues/27#issuecomment-2033881324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLMTYVKHSO7YRFNZ3NQRLY3O3SJAVCNFSM6AAAAABFSU4QXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTHA4DCMZSGQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Todd Garza @.*** 512-777-9186 https://www.linkedin.com/in/toddgarza

washikano commented 2 months ago

The MIT license is already compatible with Cardinal, there is no need to change the license for this project to be included ^^ (EDIT: both FT88 and Recursive used in this project are OFL too, so no issues there either)

If the maintainer is ok with it, we could use Cardinal specific tricks for light mode since these modules don't have a light mode

I'd love to try my hand at porting these modules

gibbonjoyeux commented 2 months ago

Glad to hear that ! When you say light mode, is it about light panels or light CPU ?

About porting Biset modules to Cardinal, that would be really really cool ! I just pushed 3 new modules I really like this week to the VCV library but they have not been reviewed yet for potential compilation error though.

washikano commented 2 months ago

Hello! Sorry, I meant light panels

For modules that don't have dark mode panels, for example, the colors can be inverted at runtime without modifying the module's resources; the same can be done for modules that don't already have light mode panels

Cardinal tries to follow upstream as closely as possible, sometimes any errors encountered are because the module needs a Cardinal-specific patch, but we'll find out ^^

gibbonjoyeux commented 2 months ago

Ooh I didn't know about this feature, it's really cool ! Ok, got it, thanks a lot !

dromer commented 2 months ago

@taji please stop telling projects they need to change their licenses without checking first if they are compatible or not.

@gibbonjoyeux I think the biggest hurdle would be how to make Tracker compatible with Cardinal, as it currently requires direct access to MIDI devices, which is not allowed.

gibbonjoyeux commented 2 months ago

Midi device usage is not mandatory for the Tracker to be usable, you can still input notes and everything. You would just not be able anymore to play synths without selecting the Tracker.

Would this require some kind of compilation condition ? The Tracker modules would not necessary be the most useful modules in Cardinal I think as you can already compose traditionally in the DAW and control knobs and all. The Blank, VCOs, generative sequencers and the coming filter/vco modules would probably be more useful

taji commented 2 months ago

@taji please stop telling projects they need to change their licenses without checking first if they are compatible or not.

Sure, no worries. :-). I want to be careful in the future to do this right, so 1) should I be reaching out to other developers at all? Or 2) is it the wording of my request? I can word it differently like "Please consider contributing to Cardinal, etc?" Is that the correct appoach?

dromer commented 2 months ago

Sure, requesting if a dev wants to contribute is fine of course, but specifically mentioning licensing requirements assumes that you understand what this means ;)

You could start by looking at the currently included modules and which licenses they use: https://github.com/DISTRHO/Cardinal/blob/main/docs/LICENSES.md

In the case of dark/light mode modifications it is preferred that the modules implement the (new) API in Rack, and otherwise that they allow us to make run-time modifications: https://github.com/DISTRHO/Cardinal/blob/main/docs/LICENSE-PERMISSIONS.md

taji commented 2 months ago

Ah, okay I understand. This is great. Thanks!