gibbonjoyeux / VCV-Biset

VCV Rack Biset modules library
GNU General Public License v3.0
42 stars 3 forks source link

Compile failure on macOS platform #3

Closed cschol closed 10 months ago

cschol commented 11 months ago

Compile failure on macOS platform with Rack Plugin Toolchain:

src/Tracker/TrackerDisplay-draw_pattern.cpp:304:5: error: use of undeclared identifier 'itoa'; did you mean 'itoaw'?                                                                                                                                                                                                   
                                itoa(note->pitch / 12, str, 10);                                                                                                                                                                                                                                                       
                                ^~~~                                                                                                                                                                                                                                                                                   
                                itoaw                                                                                                                                                                                                                                                                                  
src/Tracker/../Tracker/Tracker.hpp:575:6: note: 'itoaw' declared here                                                                                      
void itoaw(char *str, int number, int width);                                                                                                              
     ^                                                                                                                                                                                                                                                                                                                 
src/Tracker/TrackerDisplay-draw_pattern.cpp:304:10: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'int'                     
                                itoa(note->pitch / 12, str, 10);                                                                                           
                                     ^~~~~~~~~~~~~~~~                                                                                                                                                                                                                                                                  
src/Tracker/../Tracker/Tracker.hpp:575:18: note: passing argument to parameter 'str' here                                                                  
void itoaw(char *str, int number, int width);                                                                                                              
                 ^                                                                               

Also:

src/Tracker/../components.hpp:518:23: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                this->color_font = {0, 0, 0, 1};
                                    ^~~~~~~~~~
                                    {         }
In file included from src/Tracker/Tracker.cpp:2:
In file included from src/Tracker/../Tracker/Tracker.hpp:5:
In file included from src/Tracker/../Segfault/../plugin.hpp:3:
In file included from /home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include/rack.hpp:35:
In file included from /home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include/helpers.hpp:7:
In file included from /home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include/app/PortWidget.hpp:5:
/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include/engine/Module.hpp:157:23: error: 'rack::engine::SwitchQuantity::labels' is not a member of class 'ParamQuantityMode'
                sq->SwitchQuantity::labels = labels;
                    ~~~~~~~~~~~~~~~~^
cschol commented 10 months ago

More compile failures:

x86_64-apple-darwin20.2-clang++-libc++ -std=c++11 -stdlib=libc++  -fPIC -I/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include -I/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/dep/include -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -DARCH_X6
4 -march=nehalem -DARCH_MAC -mmacosx-version-min=10.9  -c -o build/src/TrackerDrum/TrackerDrumDisplay.cpp.o src/TrackerDrum/TrackerDrumDisplay.cpp         
In file included from src/TrackerSynth/TrackerSynth.cpp:2:
In file included from src/TrackerSynth/TrackerSynth.hpp:5:
In file included from src/TrackerSynth/../plugin.hpp:12:                                                                                                   
src/TrackerSynth/../components.hpp:516:24: warning: suggest braces around initialization of subobject [-Wmissing-braces]                                   
                this->color_back = {{1, 1, 1, 1}};
                                     ^~~~~~~~~~ 
                                     {         }                                                                                                           
src/TrackerSynth/../components.hpp:517:24: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                this->color_font = {{0, 0, 0, 1}};                                                                                                         
                                     ^~~~~~~~~~                                                                                                            
                                     {         }                                                                                                           
src/TrackerSynth/TrackerSynth.cpp:31:31: error: reference to 'string' is ambiguous
                configOutput(OUTPUT_CV + i, string::f("CV %d", i + 1));                                                                                    
                                            ^                                                                                                              
src/TrackerSynth/../Segfault/../plugin.hpp:8:15: note: candidate found by name lookup is 'string'
using                           std::string;                                                                                                               
                                     ^                                                                                                                     
/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include/string.hpp:10:11: note: candidate found by name lookup is 'rack::string'
namespace string {                                                                                                                                         
          ^                                                                                                                                                
2 warnings and 1 error generated.           
gibbonjoyeux commented 10 months ago

Version: 2.0.5 Fixed hash: 7839370586fba46020357a0b066f19ca3aabdf91

cschol commented 10 months ago

Confirmed.