search

gibbonjoyeux / VCV-Biset

VCV Rack Biset modules library
GNU General Public License v3.0
37 stars 3 forks source link

Tracker crashes Rack when editing note values with QWERTY keyboard #4

Closed nathansnider closed 7 months ago

nathansnider commented 7 months ago

Any time I try to enter a note in the Tracker module via the computer keyboard, it immediately crashes Rack. This happens even using an empty project with no other modules, so Tracker is the only possible culprit. The crash only happens when hitting keys that are valid notes on the QWERTY keyboard. For instance, typing A or 4 while in the note field will not cause a crash, while hitting Q or 3 will cause a crash. Editing the numerical fields in Tracker appears to work fine.

I am using the most recent version of Rack Pro (2.4.1) on Windows 10. The keyboard is a standard QWERTY keyboard.

UPDATE: The crash apparently only happens when there is no synth instance in the side display. After one is added, notes can be entered normally without crashing. Perhaps a fix for this issue would be to initialize the module with one synth instance already added.

gibbonjoyeux commented 7 months ago

Thanks again, this is a huge bug I didn't notice ! I tried to reproduce the bug and it also crashed, I think that this is due to the absence of synth (not the module, synth in the list on the side display in tracker view) while editing the pattern. This should be an easy fix, I'll try to send it today with the batch I already sent a few days ago :)

gibbonjoyeux commented 7 months ago

Fix sent ! Like the other bugs, it should be reviewed by the VCV team and updated to the library in a few days :)

nathansnider commented 7 months ago

That's great! I'll be sure to check out the update when it's in the library. Thanks for these wonderful modules, and thanks for the bugfixes. I'm really excited to have a proper tracker in VCV Rack.