search

gibilogic / tinymce-bundle

Bundle for connecting TinyMCE (WYSIWYG editor) to your Symfony2 project
7 stars 5 forks source link

Outsource TinyMCE #1

Closed MisatoTremor closed 9 years ago

MisatoTremor commented 9 years ago

Similar to how MopaBootstrapBundle handles this:

Also see stfalcon/TinymceBundle#139

Ingannatore commented 9 years ago

Why did you add the /Resources/public/vendor/tinymce folder to .gitignore? That folder should not be present anymore after the outsourcing, right?

RubenHarms commented 9 years ago

@ingannatore That folder is used for Symlinking, so it should be ignored. On environments like Windows, the folder is used for hard copy. @MisatoTremo correct me if I'm wrong.

I Love this PR (+1)

MisatoTremor commented 9 years ago

Yes :)

MisatoTremor commented 9 years ago

I rebased the branch on this forks master.

Also fixed whitespace error in composer.json (some lines now hat tabs instead of spaces).

@Ingannatore I removed all the IDE and system specific and obsolete rules from .gitignore. You should always add them to your computers global .gitignore instead. If all people working on a project would add theirs, it would needlessly bloat the project .gitignore. :D

zanardigit commented 9 years ago

I agree with the idea of removing specific IDE settings from the project .gitignore file. @Ingannatore unless you have anything to add, I'm merging this. I'll wait until Monday.

Ingannatore commented 9 years ago

@MisatoTremor: you're totally right; I always forget about the global .gitignore :D

@zanardigit: everything is ok for me; see you on monday!

MisatoTremor commented 9 years ago

@zanardigit Would you please consider tagging this as a release, so it can be used as a version constraint?

Edit: After #3 has been merged.

zanardigit commented 9 years ago

Sure, we plan to create an actual release once some minor issues have been fixed.