Make templating.helper.assets optional and use request_stack

gibilogic / tinymce-bundle

Bundle for connecting TinyMCE (WYSIWYG editor) to your Symfony2 project

7 stars 5 forks source link

Make templating.helper.assets optional and use request_stack #17

Closed MisatoTremor closed 8 years ago

MisatoTremor commented 8 years ago

The templating.helper.assets is optional in Symfony 3.0 Instead of using request directly use the stack

Ingannatore commented 8 years ago

Did you already test these changes (both on Sf 3.x and on Sf 2.x)?

MisatoTremor commented 8 years ago

Thanks for your comment, I oversaw the BC break for 2.1-2.3, which I now resolved.

For versions having the request_stack (>=2.4) it will be used, for the earlier ones the request service will be used directly. Sf 3.x no longer has the request service.

zanardigit commented 8 years ago

@Ingannatore this is ok for me, is it ok for you to merge?

Ingannatore commented 8 years ago

Merged! :)