gibilogic / tinymce-bundle

Bundle for connecting TinyMCE (WYSIWYG editor) to your Symfony2 project
7 stars 5 forks source link

add tinymce options : convert_urls, relative_urls, document_base_url #18

Closed nykopol closed 8 years ago

nykopol commented 8 years ago

I added this 3 options because i needed this in hurry, but we should probably think about something more global for the future. Maybe an open parameter that would be passed as is to tinyMce.

zanardigit commented 8 years ago

Thanks @nykopol I will review this as soon as possible.

Ingannatore commented 8 years ago

Did you already test these changes (both on Sf 3.x and on Sf 2.x)?

Maybe an open parameter that would be passed as is to tinyMce.

You read my mind :)

nykopol commented 8 years ago

@Ingannatore i tested it on 2.7 and it's working. From my experience, this changes are compatible from at least 2.3 to 2.8. For the compatibility again 3.* according to the upgrade documentation, the Config component has only small changes that does not affect this modifications, so i think that it's compatible with 3.* to.

zanardigit commented 8 years ago

@nykopol Symfony 3.0 is just 2.8 without deprecated features, so if you can test on 2.8 and make sure you have no deprecated that would be great.

The JS changes are obviously not related to Symfony version so I'm already ok with those.

scalarNode and defaultNull are there since at least Symfony 2.0 so backward compatibility is ok as well.

nykopol commented 8 years ago

I confirm that it's work on 2.8 without deprecation.

nykopol commented 8 years ago

can you please tag a new version that contain this PR ?

Ingannatore commented 8 years ago

Done: tagged as 1.2.0.

nykopol commented 8 years ago

thanks a lot