[WIP] one open parameter for TinyMCE configuration

gibilogic / tinymce-bundle

Bundle for connecting TinyMCE (WYSIWYG editor) to your Symfony2 project

7 stars 5 forks source link

[WIP] one open parameter for TinyMCE configuration #21

Closed nykopol closed 8 years ago

nykopol commented 8 years ago

I'm starting to work on #19 realize that some questions need to be discussed.

do we keep the compatibility with current configuration version ?
the 3 options include_jquery tinymce_jquery and use_callback_tinymce_init are not TinyMCE config options, but there are mixed with it in tinymce_init() Twig function. How do we handle that ?

From a general point of view : do we keep a full compatibility with the current implementation ? Or we accept some BC break to keep the implementation more light ?

Ingannatore commented 8 years ago

I would vote for accepting some BC breaks.

About the bundle's configuration, I would do something like that:

stfalcon_tinymce:
    include_jquery: ~
    tinymce_jquery: ~
    use_callback_tinymce_init: ~
    tinymce_config: ~

tinymce_config would be our "open parameter".

nykopol commented 8 years ago

Hello guys, i think it's OK for this one. The tinymce_config is passed from the config of Symfony to TinyMCE without any problem. The documentation is updated, and for the boring engineer ;) i have tested this changes from sf2.3 to 2.8 without exception.

So i this this PR can be merged.

zanardigit commented 8 years ago

@Ingannatore please tag and release 1.3.0 when you have some time.

Ingannatore commented 8 years ago

@zanardigit Done!