Closed nykopol closed 8 years ago
I would vote for accepting some BC breaks.
About the bundle's configuration, I would do something like that:
stfalcon_tinymce:
include_jquery: ~
tinymce_jquery: ~
use_callback_tinymce_init: ~
tinymce_config: ~
tinymce_config
would be our "open parameter".
Hello guys, i think it's OK for this one. The tinymce_config
is passed from the config of Symfony to TinyMCE without any problem. The documentation is updated, and for the boring engineer ;) i have tested this changes from sf2.3 to 2.8 without exception.
So i this this PR can be merged.
@Ingannatore please tag and release 1.3.0 when you have some time.
@zanardigit Done!
I'm starting to work on #19 realize that some questions need to be discussed.
include_jquery
tinymce_jquery
anduse_callback_tinymce_init
are not TinyMCE config options, but there are mixed with it intinymce_init()
Twig function. How do we handle that ?From a general point of view : do we keep a full compatibility with the current implementation ? Or we accept some BC break to keep the implementation more light ?