search

gibilogic / tinymce-bundle

Bundle for connecting TinyMCE (WYSIWYG editor) to your Symfony2 project
7 stars 5 forks source link

Fix merging process form theme configuration #24

Closed nykopol closed 8 years ago

nykopol commented 8 years ago

Since the lasts changes with the introduction of the tinymce_config parameter it was not possible to overwrite a sub-part of the theme parameters.

Relying on the normalization to define the default mandatory parameters was breaking the merging process when using with prepend configuration (for example, overwriting the toolbar parameter of the simple theme was producing an empty configuration). Secondly, the merging of this parameter in javascript was failing as well.

This PR define the default configuration for TinyMCE at validation time (after the merging process) and fix the merging process in javascript by using a similar $.extend() function in bare JS.

As always, this changes are tested successfully from sf2.3 to 2.8, with and without jQuery. I hope that you can review that quickly and add a new tag as it's blocking for me. Thanks in advance.

Ingannatore commented 8 years ago

Added into the 1.3.1 version.

nykopol commented 8 years ago

thanks a lot @Ingannatore