gibson042 / canonicaljson-go

Go library for producing JSON in canonical format.
https://godoc.org/github.com/gibson042/canonicaljson-go
Other
20 stars 2 forks source link

git submodule update / git clone --recursive #3

Closed piedup closed 6 years ago

piedup commented 6 years ago

Hello,

We are using canonicaljson-go for one of our projects. We have automated the deployment of our application using golang/dep. dep uses git clone --recursive to fetch the submodules. The .gitmodules file in canonicaljson-go points to git@github.com:gibson042/canonicaljson-spec.git so git clone --recursivewill use ssh to fetch the submodule. Unfortunately that doesn't work when no ssh key has been setup, which is the case for instance in a docker container.

Do you think you could update the .gitmodules so that it points to https://github.com/gibson042/canonicaljson-spec.git instead? This will allow git clone --recursive and git submodule update to work without using ssh keys.

Thank you for your help. Pierre

gibson042 commented 6 years ago

Sure, seems reasonable.

piedup commented 6 years ago

Thanks