implement pull-check - Githubissues

them2dt commented 3 months ago

This pull request was created by https://app.gib.work/i/qk15AsYz/bounty-for-manu in an attempt to solve a bounty. Payment for the bounty is immediately sent to the contributor after merge.

NiKHiLkr23 commented 3 months ago

Thank you for submitting this PR! @them2dt 🔥 I've reviewed the code and identified a few areas for improvement and potential issues. Below are the changes and suggestions to enhance the code's functionality, security, and user experience:

Security: The GitHub access token is hardcoded in the source code.
Error Handling: The catch block lacks error logging, which makes debugging difficult.
Input Validation: The validation of the input parameters is incomplete and may lead to runtime errors.
Polling: There is no mechanism to continuously check the PR status at regular intervals.
Code Duplication: The response object is being parsed multiple times.
Efficiency: Creating a new instance of Octokit on every run function execution is unnecessary and inefficient.

Please make sure we have a pr that we can run and test on our end. Do reach out to us, if you have any question. Looking forward to the changes, thank you!

them2dt commented 3 months ago

Applied requested changes.

enhanced error-handling
input gets validated better
continuosly checking the pull request status within an interval of 60 seconds
added animation elements for a smooth experience
exported the access token to an .env file
octokit instance gets created on page render

You can test out the updated page on: https://gibwork-test-01.vercel.app/

Looking forward for your feedback!

gibwork / test-01

implement pull-check #2