gicait / PyAEZ

PyAEZ is a python package consisted of many algorithms related to Agro-ecalogical zoning (AEZ) framework.
MIT License
78 stars 53 forks source link

Module2 CropSimulation generates different output #38

Open imryoung9898 opened 1 year ago

imryoung9898 commented 1 year ago

When the simulation is done the code generates something different from the one that you've uploaded on github. Specifically, my outputs (both LAO_CropSuitability_rain and LAO_CropSuitability_irr) are 1296 times the desired output. I was wondering where this number is from.

I'm also curious about which crop we've estimated for. The code uses parameters of LAI=2.3 and HI=0.33 with the growing cycle = 115, but I failed to find a specific crop and input type (high or low) pair that matches this setting. Thank you in advance.

NokuzaSezo97 commented 1 year ago

Dear @imryoung9898,

My apologies for this late reply. FYI, The crop included in NB2_CropSimulation is a nationalized parameters corresponding to rice (for Laos), thus, obviously you won't find in GAEZ database exactly as notebook mentioned. But the yield obtained for that crop in your simulation (assuming you have yield around 5000-7000 kg/ha) is correct, when compared to data output uploaded in our GitHub repository. This might happen during merging final code from our side, so incorrect outputs for NB2 are being saved. Apologies for that. For now, please ignore the files in NB2 data outputs. Just what you obtained are correct.

I hope these answers will clarify for you. Let us know if you have more questions.

Warm regards,

Swun Wunna Htet

imryoung9898 commented 1 year ago

Thank you for the clarification! Quick follow-up question : What do you mean by 'nationalized parameter'? Does it mean that we need to use different params for each country? e.g. rice have different parameters for Laos and Vietnam?

NokuzaSezo97 commented 1 year ago

Dear @imryoung9898,

Generally yes. By theory, national AEZ analysis uses crops of specifically unique phenological characteristics/species types, which is a suggestion for NAEZ projects. For Laos example, the crop parameters were evaluated and decided by Laos agronomists, and AEZ experts together.

However as you might know, that the crop information used in AEZ is very detailed and practically require quite a lot of parameters that not every country might be accessible or obtained. In such scenario, one can utilize global crop database, which GAEZ have one publicly accessible: https://s3.eu-west-1.amazonaws.com/data.gaezdev.aws.fao.org/documentation/GAEZ4_Appendices.xlsx. Again, in Laos, some of the parameters are also referred from this as well.

As you check on the provided database, you will encounter same crops with different crop parameters (by GAEZ concept, it's referred to Land Utilization Type (LUT)). So, if you don't have nationalized parameters, at least you can visit this data for using in PyAEZ, regardless of different locations.

Thanks for your interest in PyAEZ. Hope these will help you in your research endaveour.

Regards,

Swun Wunna Htet