search

gicait / geoserver-rest

Python library for management of geospatial data in GeoServer.
https://geoserver-rest.readthedocs.io
MIT License
197 stars 79 forks source link

Enable more customization of `requests` usage #133

Closed fleimgruber closed 5 months ago

fleimgruber commented 10 months ago

As a user, I want to use geoserver-rest with a GeoServer instance that provides self-signed SSL certificates.

As a user, I would like to customize the functions using the requests package to set verify=False, see docs.

A possible solution would be to accept a **kwargs in the user-facing APIs, e.g. get_featurestore https://github.com/gicait/geoserver-rest/blob/d07ee027badc00c3a8ba968131b91fd7e5d0e284/geo/Geoserver.py#L2050

and pass those **kwargs to the requests call https://github.com/gicait/geoserver-rest/blob/d07ee027badc00c3a8ba968131b91fd7e5d0e284/geo/Geoserver.py#L2062

so that users could do get_featurestore(..., verify=False).

iamtekson commented 10 months ago

Hi @fleimgruber, I like the idea. Feel free to raise the PR if you want.

jacklinna commented 9 months ago

that sounds great