gicait / geoserver-rest

Python library for management of geospatial data in GeoServer.
https://geoserver-rest.readthedocs.io
MIT License
195 stars 77 forks source link

tidying up & attempted layergroup creation #75

Closed jeafreezy closed 2 years ago

jeafreezy commented 2 years ago

In an attempt to work on issue 64, I wrote a function to handle layergroup creation.

There are a few TODOs which highlighted in the code because Implementing some will change the location of some functions.

Also, I didn't attempt 2,3,4 in the issue because I want to get a review on this before I attempt other functions.

I look forward to your response.

jeafreezy commented 2 years ago

Hi @Zeitsperre , thank you for taking time to review the PR. I will make necessary fixes now and reopen.

iamtekson commented 2 years ago

First of all, Thank you very much @jeafreezy for your valuable contribution to this package. Also thank you very much @Zeitsperre for your quick review. Before merging it into the master branch, I will also review the changes. I will manage some time this week.

jeafreezy commented 2 years ago

Sounds good.! Thanks for the great work @iamtekson!

jeafreezy commented 2 years ago

Thanks for the review @iamtekson , will implement the corrections and attempt other methods of the layer group