gicait / geoserver-rest

Python library for management of geospatial data in GeoServer.
https://geoserver-rest.readthedocs.io
MIT License
195 stars 77 forks source link

Remove the "rest" from Geoserver class URL: It is making confusion for old users #77

Closed iamtekson closed 2 years ago

iamtekson commented 2 years ago

As @jeafreezy suggested, we have added the rest at the end of Geoserver class parameter URL as below,

from geo.Geoserver import Geoserver
geo = Geoserver("http://localhost:8080/geoserver/rest", username="admin", password="geoserver")

And also we remove the rest from the methods of the Geoserver class. I think this is the breaking change in v2.3.0. Due to this, the previous version user faced lots of problems. So I am reverting the geoserver URL to the original URL without rest. I think we can think about the v3.0.0 for this breaking change. After solving this issue, the geoserver-rest will come back to the previous style as below,

from geo.Geoserver import Geoserver
geo = Geoserver("http://localhost:8080/geoserver", username="admin", password="geoserver")

# Create workspace test
geo.create_workspace("test")
iamtekson commented 2 years ago

PS: I yanked the previously released versions v2.3.0 and v2.3.1. Now with the new version v2.3.2, I believe everything is working well.

jeafreezy commented 2 years ago

Welldone @iamtekson . I agree with you, we can release this in higher version.