search

gicentre / elm-vegalite

Elm - Vega-Lite Integration for functional declarative visualization
BSD 3-Clause "New" or "Revised" License
73 stars 11 forks source link

Data ingestion: Apache Arrow #46

Closed RalfNorthman closed 1 year ago

RalfNorthman commented 1 year ago

I had trouble getting my project to work after I switched from a csv to an arrow data source. As a sanity check I served the elm-vegalite examples folder. All the regular examples seemed to work just fine, but the one with arrow had the same behavior as in my project: empty visualizations and browser dev tools talking about WARN Data ingestion failed and TypeError: e.Table.from is not a function.

arrow-plots-empty arrow-error-dev-tools

I was hoping vega-loader-arrow would have a similar example I could test but I just found a link to a deployed observable notebook (that worked).

Is there something wrong on my end (how I serve the files etc) or is this a bigger issue?

EDIT: I just cloned the repo to my local machine and opened the example html-files by clicking on them in the file explorer. Same behaviour.

jwoLondon commented 1 year ago

Thanks for raising this one. I've added an issue to Vega-lite as it looks like there has been an API change with vega-loader-arrow: https://github.com/vega/vega-lite/issues/8898

Will report back here if/when we get a solution.

jwoLondon commented 1 year ago

Problem now fixed thanks to Vega-loader-arrow update from @domoritz to use new arrow API. This shouldn't need any changes for users of elm-vegalite (but you may have to clear caches for any recent arrow tests that were using the older version of Vega-loader-arrow).

RalfNorthman commented 1 year ago

These are great news! Thanks!