[Feature Idea] Remove Padding of built-in images

gickowtf / pixoo-homeassistant

Home Assistant Integration for Divoom Pixoo 64

MIT License

112 stars 12 forks source link

[Feature Idea] Remove Padding of built-in images #37

Closed Mrredstone5230 closed 5 months ago

Mrredstone5230 commented 5 months ago

Before, there was a 1px gap around all images in divoom_pixoo/img (weather not affected).

(This is how it looked in PyCharm. The black around the shape is black, and not transparent, which could "overwrite" stuff that's under it.)

Mrredstone5230 commented 5 months ago

I think I used the wrong word. I think "border" would be more appropriate than padding. My PR removed the black border around the built-in images.

gickowtf commented 5 months ago

hey i'm sorry that i'm only reacting now. so in this case the border doesn't really bother, but in case the pictures are used for own pages you are right if you need a border you can put a rectangle underneath ;D... I will merge the PR but will not make a new version for it now but with the next release