Closed yyolk closed 5 months ago
i would be very happy if you would concentrate on the essentials when making changes and not replace ' with ". this way i have to check the entire code for changes because more lines have been changed accordingly. otherwise i will gladly adopt your idea :D
i would be very happy if you would concentrate on the essentials when making changes and not replace ' with ". this way i have to check the entire code for changes because more lines have been changed accordingly. otherwise i will gladly adopt your idea :D
Sure, I've narrowed the formatting to one commit, but if its helpful I'll drop it entirely
i would be very happy if you would concentrate on the essentials when making changes and not replace ' with ". this way i have to check the entire code for changes because more lines have been changed accordingly. otherwise i will gladly adopt your idea :D
Sure, I've narrowed the formatting to one commit, but if its helpful I'll drop it entirely
No no no, I think it's fiiiiine. I think it was needed anyways.
i would be very happy if you would concentrate on the essentials when making changes and not replace ' with ". this way i have to check the entire code for changes because more lines have been changed accordingly. otherwise i will gladly adopt your idea :D
Sure, I've narrowed the formatting to one commit, but if its helpful I'll drop it entirely
No no no, I think it's fiiiiine. I think it was needed anyways.
haha ok, I already force-pushed an update - looks like theres more for me to change 😄
so if it's okay I'll run formatting on the file at the end of an approving review
no problem it's not urgent... give me a sign when you are ready. i test every time anyway and then write the readme directly... i don't think i do anything else anymore -.-
no problem it's not urgent... give me a sign when you are ready. i test every time anyway and then write the readme directly... i don't think i do anything else anymore -.-
well if it's helpful, I started the README changes in b594d5dc3dfffd733293f4fc85a07e9dd96d6c48!
Adds the ability to include a
time_end
parameter to thepage_data
passed into aprogress_bar(...)
page.I use progress_bar for displaying timers, I thought since there's so much space underneath the progress bar it would be nice to include a
time_end
which is really up to the caller to decide if it's an estimate or the exact time the progress bar will reach 100%After feedback, the
time_end
parameter requires the user to render the expected time, which is also like the PV/Solar page. What is passed in is just a string.Here's an example
page_data
for the service call that includes some context unrelated to these changes, mainlytimer_name
andprogress
are fetched from a call to another script before this service call.I opted for a "light grey"
rgb(151, 151, 151)
as the defaulttime_end_color
, but I don't really have a strong opinion. My thinking was it should look different than the time above and this was a quick way to achieve that, it is also customizable like thetime_color
is.And here's how it looks (please excuse the bad photo, the light grey doesn't look this muted and I think is more legible):
As another example situation where I use the progress_bar page in my normal rotation of pages, set on the integration configuration is like during the work day which also are fed from a timer, but is a template helper (sensor) I've created off the work_day timer and could make use of the
time_end
parameter.The sensor state as the value for
time_end
is atimestamp
device class.Please let me know if I should change anything if this could be an acceptable feature.
This was my first time testing a custom integration on my only home assistant install - so please let me know if I missed anything!