gicmo / gamemode-extension

GNOME Shell extension for Feral Interactive's GameMode
GNU Lesser General Public License v2.1
148 stars 17 forks source link

Add support to GNOME Shell 3.38 #31

Closed ranisalt closed 3 years ago

ranisalt commented 3 years ago

I have installed it manually and it has been working great.

laichiaheng commented 3 years ago

2 months has passed.

ranisalt commented 3 years ago

Still working great.

laichiaheng commented 3 years ago

Still doesn't work via AUR.

Redbatman89 commented 3 years ago

The extension is giving me errors in gnome logs

Object .Gjs_gamemode_christian_kellner_me_extension_GameModeIndicator (0x5565b80a8c60), has been already deallocated — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.

Object St.Icon (0x5565b7d04800), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.

vanvugt commented 3 years ago

@ranisalt, I'm confused. Are you saying 3.38 works or that it doesn't work? If the latter then it's Ubuntu bug 1917098.

Also, the issue mentioned above by @Redbatman89 is #35.

ranisalt commented 3 years ago

@ranisalt, I'm confused. Are you saying 3.38 works or that it doesn't work?

It's working great. I mean no issues at all. Icon is there, turns green when activated and all.

vanvugt commented 3 years ago

@ranisalt, I'm confused. Are you saying 3.38 works or that it doesn't work?

It's working great. I mean no issues at all. Icon is there, turns green when activated and all.

Please close this issue then.

ranisalt commented 3 years ago

No, it still does not mark 3.38 as supported

vanvugt commented 3 years ago

Oh, right. In that case please clarify in the bug description that the problem is just metadata.json.in.

gicmo commented 3 years ago

3.38 should be supported in release 5. Thanks for your patience, sorry it took so long.