search

gicmo / gamemode-extension

GNOME Shell extension for Feral Interactive's GameMode
GNU Lesser General Public License v2.1
148 stars 17 forks source link

Enable "Do Not Disturb" when active (#15) #51

Open devmattrick opened 2 years ago

devmattrick commented 2 years ago

This PR adds the "Do Not Disturb" toggle functionality that was mentioned in #15. This is also my first time working on writing GNOME extensions so please let me know if this could be improved in any way.

A small bug that I'm not entirely sure how to fix is there seems to be an issue where the "GameMode is inactive" notification gets sent before "Do Not Disturb" is fully disabled, which leads to the notification not popping up (it still is in the notification area, though). I'd be happy to fix this if anyone has any ideas on how to wait for the setting change to take effect.

Thank you for the awesome extension!

gicmo commented 2 years ago

So sorry, totally missed this! I will have a look asap!

gicmo commented 2 years ago

I think it might need adaptions now that #54 landed (sorry).

devmattrick commented 2 years ago

No worries! I'll work on it when I get a chance.

I think I may also need to make it handle computer restarts because it's possible for do not disturb to get turned on and remain on after the computer restarts.

devmattrick commented 2 years ago

@gicmo this should be ready for review! I believe the failing CI build may be unrelated to this PR but let me know if I inadvertently broke something :slightly_smiling_face:

Feel free to request changes as you see necessary!