gicmo / gamemode-extension

GNOME Shell extension for Feral Interactive's GameMode
GNU Lesser General Public License v2.1
149 stars 17 forks source link

Add support for gnome-shell 42 and Libadwaita #54

Closed fjsevilla-dev closed 2 years ago

fjsevilla-dev commented 2 years ago

This PR should provide support for Gnome 42, while implementing the use of Libadwaita widgets for this version and maintaining backwards compatibility with previous versions. I've tested it on Gnome 41 and 42 and there don't seem to be any problems.

Some notes:

Just as a note, originally it used composite templates (.ui files) but since the extension doesn't make use of them and the interface is relatively simple, I've dropped it. However, the window can be fully defined in a .ui file if desired, including assigning its respective key in GSettings. I don't think it has much importance, but if it turns out to be convenient in the future, the possibility exists.

Resolves #52, resolves #53

fjsevilla-dev commented 2 years ago

Hi @gicmo, I have made this PR based on your comment in #53. I'm aware that I have basically rewritten everything for the new version 😳, so feel completely free to comment on anything that you think is wrong, that could be improved or that you would simply like differently in the implementation, in the code style, variable/class/property names, visual appearance or any other aspect.

gicmo commented 2 years ago

Love this!

gicmo commented 2 years ago

Love this!

mhalano commented 2 years ago

@gicmo Do you have a release date for the newer version with this change? I ask that because I'm already using Ubuntu 22.04 which comes with GNOME 42. :smile_cat:

gicmo commented 2 years ago

@mhalano let me try to find some free time this week.

highvoltage commented 2 years ago

Could you tag a new release too? thanks for all your work!