search

gid-oss / dataui-nestjs-crud

NestJs CRUD for RESTful APIs
https://github.com/nestjsx/crud/wiki
MIT License
124 stars 32 forks source link

feat: add array operators #21

Closed afilp closed 10 months ago

afilp commented 11 months ago

More info here: https://github.com/nestjsx/crud/pull/754

zaro commented 11 months ago

@afilp unfortunately tests are failing with this change. I spend some time trying to figure out what causes it, but it's not obvious at all.

I don't have time in the next few days to figure it out, so it will have to wait until I have time...

afilp commented 11 months ago

Sure!

I just copied/pasted the old code from that PR: https://github.com/nestjsx/crud/pull/754

So, that you can have a start. Most likely that old code would fail somewhere.

zaro commented 10 months ago

@afilp this is merged and released as 5.3.1 .

afilp commented 10 months ago

@afilp Does it work eventually? Without any changes? Thanks!

zaro commented 10 months ago

@afilp I don't understand do you mean?

Install v5.3.1 and check if it's working. I fixed the tests, but I didn't have time to test the two new array operators. The branch is actually meged, but I closed the PR, because it was way more work to merge it trough the PR.

As for the changes, I had to make a trivial change because of small refractor that this PR is doing.