Fix: duplicate column selection issue in getMany with joins and pagination

ZaidMaslouhi commented 8 months ago

This pull request proposes a fix for the duplicate column names encountered when using getMany with joins and pagination in NestJS CRUD #788.

The current solution in #788 excludes the "id" column, which might not be ideal for all relational scenarios. This pull request aims to address duplication directly within the column array, preserving the "id" column when necessary or any duplicated column.

Key points:

[X] Solves duplicate column issue identified in #788.
[X] Maintains "id" column inclusion for relational cases.
[X] Implements logic to remove duplication within the column array.

Please review and provide feedback on the proposed approach.

issue #32

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 8367170228

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.665%

Totals
Change from base Build 8258247547:	0.0%
Covered Lines:	1244
Relevant Lines:	1251

💛 - Coveralls

zaro commented 8 months ago

@ZaidMaslouhi Thank you for your contribution.

The fix is released as 5.3.3

ZaidMaslouhi commented 8 months ago

you're welcome ! 🫡

gid-oss / dataui-nestjs-crud