search

giecaruff / stoneforge

Algoritmos, métodos e equações de geofísica do appy
MIT License
6 stars 6 forks source link

dependencies version #7

Closed mmramos closed 2 years ago

mmramos commented 2 years ago

it's not better to set, for example, "numpy>=1.20.0" or "pytest>=6.2.2" instead of "numpy==1.20.0"?

My argument is that this will made stoneforge more flexible for any subsequent modification on appy-core and appy-gui.

rmotadutra commented 2 years ago

I'm not sure if this is the best option for the packages versions. But, for the python version I think the best option is to set python>=3.8.8.

fabiojdf commented 2 years ago

I'm not sure too. Maybe by this way a version 2.x of some package will be installed and could broke some functionalities of stoneforge. I don't know if "numpy>=1.20.0" will install only 1.x versions.

mmramos commented 2 years ago

Good questions, I put an attached image of the test that I made. The installation was made in a clean environment only with python 3.8.8 numpy and pytest are the latest version.

A test was made also using “...python>=3.8” and I get a crash.

issue_python_version_1 issue_python_version_2

I made a final attempt here that appears to be the best using "numpy>=1.20.0, <=1.25.0" issue_python_version_3

I think the last one is the best way