search

giejay / Immich-Android-TV

An Android TV app for the self hosted photos and videos backup solution.
GNU General Public License v3.0
208 stars 9 forks source link

Blurry Photos [BUG] #12

Closed Philshappy closed 7 months ago

Philshappy commented 7 months ago

My configuration. My photo library is located on an NAS and mounted as an external libraryin Immich. Settings for thumbnails are 4K. Browser displays all images crisp and focused. No issues. Immich is running in Unbuntu on a dedicated server. My NAS sleeps in the evening but the photos are still available when using a browser because I believe the 4K thumbnails are being displayed from the server and not from the external library located on the NAS.

Describe the bug NAS is off. When flipping through either photos or albums after a few photos some of the photos are blurred, as if they were being displayed as a lower resolution. Some were OK as if they are being displayed in the 4K resolution. The issue appears to correct itself when I turned on my NAS.

To Reproduce External library on NAS, 4K thumbnails, NAS off, flip through photos.

Expected behavior Photos to be displayed in 4K with external library offline or online.

Screenshots NA

My setup (please complete the following information):

giejay commented 7 months ago

So those pictures which are blurry are not stored on the NAS itself? Somewhere on a local drive?

Philshappy commented 7 months ago

All my photos are stored on my NAS and mounted as an external library in Immich. My NAS is off at night to conserve power but all my photos are still available on Immich. Immich runs on a stand alone mini-pc running Unbuntu and is on all the time. Immich database and all thumbnails are stored on the mini-pc server. When using a browser, accessing my photos through Immich displays correctly even though my NAS is off. I believe its because Immich is displaying the photos from the thumbnails located on the mini-pc which is on all the time. It appears that sometimes your app displays the 4K images and sometimes the 256 images. Let me know how I could be more helpful.

Thanks again.

From: GJ Compagner @.> Sent: Sunday, February 18, 2024 9:04 AM To: giejay/Immich-Android-TV @.> Cc: Philshappy @.>; Author @.> Subject: Re: [giejay/Immich-Android-TV] Blurry Photos [BUG] (Issue #12)

So those pictures which are blurry are not stored on the NAS itself? Somewhere on a local drive?

— Reply to this email directly, view it on GitHubhttps://github.com/giejay/Immich-Android-TV/issues/12#issuecomment-1951386646, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDSLPUUZFVJOG4MBZA25FBDYUIYBZAVCNFSM6AAAAABDOJEK3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGM4DMNRUGY. You are receiving this because you authored the thread.Message ID: @.***>

giejay commented 7 months ago

My app will attempt to load the thumbnails first, while in the background also loading the original image. If the original image is missing (because a NAS is off for example), it will fail to load it and only show the thumbnail. If the problem does not occur when the NAS is on, there's not a lot I can do here.

Philshappy commented 7 months ago

Thanks for the quick response. Would it be possible to load the 4K thumbnail if it exists all the time. It appears to be loading the 4K sometime and the 256 othertimes.

Thanks, Phil

From: GJ Compagner @.> Sent: Sunday, February 18, 2024 10:09 AM To: giejay/Immich-Android-TV @.> Cc: Philshappy @.>; Author @.> Subject: Re: [giejay/Immich-Android-TV] Blurry Photos [BUG] (Issue #12)

My app will attempt to load the thumbnails first, while in the background also loading the original image. If the original image is missing (because a NAS is off for example), it will fail to load it and only show the thumbnail. If the problem does not occur when the NAS is on, there's not a lot I can do here.

— Reply to this email directly, view it on GitHubhttps://github.com/giejay/Immich-Android-TV/issues/12#issuecomment-1951403008, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDSLPUQRTP6LQWK7IYCSZ6LYUI7WXAVCNFSM6AAAAABDOJEK3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGQYDGMBQHA. You are receiving this because you authored the thread.Message ID: @.***>

giejay commented 7 months ago

I have added loading of higher resolution thumbnails (300KB vs 15KB) in the next release (1.24.1), should be visible in the Play Store in a few hours.

Philshappy commented 7 months ago

Thanks so much. Tested with both my NAS on and off and the photos look great on my 4K TV. I am looking forward to your upcoming new features. If it has not been suggested could you add an exit option to the menu.

Thanks again.

From: GJ Compagner @.> Sent: Sunday, February 18, 2024 10:41 AM To: giejay/Immich-Android-TV @.> Cc: Philshappy @.>; Author @.> Subject: Re: [giejay/Immich-Android-TV] Blurry Photos [BUG] (Issue #12)

I have added loading of higher resolution thumbnails (300KB vs 15KB) in the next release (1.24.1), should be visible in the Play Store in a few hours.

— Reply to this email directly, view it on GitHubhttps://github.com/giejay/Immich-Android-TV/issues/12#issuecomment-1951410731, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDSLPUVXQ7D2WUBLJ4IFIE3YUJDPPAVCNFSM6AAAAABDOJEK3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGQYTANZTGE. You are receiving this because you authored the thread.Message ID: @.***>

Philshappy commented 7 months ago

Not sure if the current implementation still fetches the original library photo but if so in the future could you add a setting for loading the original library photo or not. As cameras/phone keep increasing their resolution they are so far above what TVs can display. The Immich choice of 4K thumbnails appears to be a good compromise for now and therefore an option for only loading the highest resolution thumbnail and not loading the original would save bandwidth and processing.

Philshappy commented 7 months ago

My earlier test was a small album of 6 photos. Everything worked fine. Not so with large albums or as you open multiple albums over time the problem gets progressively worse. I opened a large album of 80 photos. When opened, it took several minutes to display all the thumbnails. As you click thru the album photos after about the first 7 photos the remaining were blank. If I continue to cycle thru the album photos some of the photos appear over time but its taking minutes to add a couple of photos. (My Immich thumbnails are stored on a dedicated Immich server and the photo library is external stored on a NAS. My NAS was off.) Then I repeated this with the NAS on and did not have this issue. Everything worked fine. It appears that the app has an issue with getting the 4K thumbnail from the server or it takes a lot of time to determine the external library is off and only display the 4K photo. I don't have this issue when using a pc browser and my NAS off, it gets the 4K thumbnails just fine and displays them very quickly. I think Immich only displays the 4K or 256 photo thumbnail (depends on setting) when using a browser allowing external libraries to be removable or unmounted because the thumbnails can be stored locally to the server. I can resolve the issue with keeping my NAS on, but I think a better long term solution is to duplicate what Immich does by displaying only the 256 or 4K thumbnail depending on the setting. Maybe an setting for downloading the full photo makes sense.

giejay commented 7 months ago

While you are seeing slow responses, I suggest to fetch the thumbnails yourself and see if thats also slow: https://immich.app/docs/api/get-asset-thumbnail

Format in query param should be JPEG. Not much more I can do from the app side I guess.

madkatz01 commented 7 months ago

Looking at this: I guess the thought is why load original files at all? For speed/simplicity, Immich in the browser only loads the two sizes of thumbnails (see photo below). Maybe that is a faster approach for the ImmichTV app and does not require anyone's external libraries to be online?

Screenshot 2024-02-19 192519
giejay commented 7 months ago

I didn't even know you could change it to 4K;) I will add it as an option to only use thumbnails instead of the native files. I guess not all people want to use it.

Philshappy commented 7 months ago

That would be great.

Thanks so much.

From: GJ Compagner @.> Sent: Tuesday, February 20, 2024 10:36 AM To: giejay/Immich-Android-TV @.> Cc: Philshappy @.>; Author @.> Subject: Re: [giejay/Immich-Android-TV] Blurry Photos [BUG] (Issue #12)

I didn't even know you could change it to 4K;) I will add it as an option to only use thumbnails instead of the native files. I guess not all people want to use it.

— Reply to this email directly, view it on GitHubhttps://github.com/giejay/Immich-Android-TV/issues/12#issuecomment-1954834032, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDSLPUXOQT6JGTLCC2SZ4NLYUTUJTAVCNFSM6AAAAABDOJEK3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJUHAZTIMBTGI. You are receiving this because you authored the thread.Message ID: @.***>

giejay commented 7 months ago

I have pushed the changes in release 1.27

Philshappy commented 7 months ago

Works really well with or without external library mounted. When disabling native photos and using high resolution thumbnails (4K) photos are displayed very fast, no delays, no spinning circles.