search

giejay / Immich-Android-TV

An Android TV app for the self hosted photos and videos backup solution.
GNU General Public License v3.0
146 stars 5 forks source link

Unable to see HEIC photos #9

Closed fivestones closed 4 months ago

fivestones commented 5 months ago

Describe the bug Most of my photos just show the loading icon for a bit and then nothing else happens when I try to view them. If I look at a png it loads immediately, and videos load and play fine, so I'm assuming this is due to the HEIC file format which most of my photos are in. The thumbnails are all visible and look good.

To Reproduce Steps to reproduce the behavior:

  1. Put HEIC photos in Immich
  2. Go to any album or the main photos section
  3. Click on any HEIC format photo
  4. The photo never loads

Expected behavior The photo should show up.

Screenshots If applicable, add screenshots to help explain your problem.

My setup (please complete the following information):

Additional context None.

giejay commented 5 months ago

Hi,

I don't have an iPhone, so could you upload an example to this album? https://giejay-immich.duckdns.org/share/MW5mEqx2jClEEwLeZuQvBVL28MwwJCeJchXvBjyK5MvA_jEU693CdI1lmRPLc_BmBCU Password: vertical

I will check if it's an OS specific version issue

giejay commented 5 months ago

Checked it and indeed, HEIC is not supported by the Glide library I'm using. Also checked if a custom loader could be used, but the HEIC Android/Java libraries are scarce so I'm afraid this can't be fixed for now.

giejay commented 4 months ago

This is sort of solved in the latest release because it will now load the 4k thumbnails. Those will load fortunately.

fivestones commented 4 months ago

Sweet! Thanks! I'm looking forward to trying this.