search

gielcobben / caption

Get Caption, start watching.
https://getcaption.co/
MIT License
1.35k stars 91 forks source link

Manual search has different than dragged in folders auto search #78

Open adro21 opened 6 years ago

adro21 commented 6 years ago

Expected Behavior

When I drag a folder into Caption it should find the same results as it does when I do manual searches. Manual searches for missing subtitles find more results than dragging in a folder.

Current Behavior

If I drag a TV show folder into Caption, it will find subtitles for some episodes but not others. If I then copy the filename of the MKV it cannot find and do a manual search in Caption, it will find several results.

Steps to Reproduce (for bugs)

  1. Drag TV folder into Caption. There will be subtitles found for some episodes but not others.
  2. Copy the filename of an MKV file which could not be found (via dragging in a TV show folder) and paste it into Caption search.
  3. Several results will be found from this manual search, but none will be found when automatically searching by dragging in a TV series/season folder.

Context

Trying to be able to get subtitles for all episodes in a season or series without having to manually do searches for each episode then manually renaming.

Your Environment

Tech Version
app version 2.0
OS MacOS
etc
vernondegoede commented 6 years ago

Hi @adro21,

Thanks for filing this issue! 🙌 The file search is slightly different from the text search. File search uses the file hash, file size and file name to find the best match on Open Subtitles.

A possible solution would be to run a text search query on all sources using the file name if no results were returned using file search. However, we don't know which of the results to pick for this specific file, since there may be multiple results when running a text search query.