search

giellalt / giella-core

Build tools and build support files as well as developer support tools for the GiellaLT repositories.
https://giellalt.uit.no
GNU General Public License v3.0
7 stars 2 forks source link

SMI-specific paths in Giella-core/am-shared #21

Closed snomos closed 2 years ago

snomos commented 2 years ago

am-shared/tools-mt-cgbased-dir-include.am includes references to gt_SHARED_smi, which is no good. It should either be in shared-mul, or in giella-core, or be completely optional. Specifically, it relates to the following lines of code.

Viewpoints, @flammie @Trondtr @lynnda-hill @leneantonsen @TinoDidriksen ?

snomos commented 2 years ago

The same goes for this file.

flammie commented 2 years ago

yeah so, I'd put optional shares that can be made to degrade gracefully-ish if missing to new shared stuff only, giella-core is good for required shares atm or could even use template-lang-und if it's to be customised more, I'm not sure how much smi rules are to be shared by copying and simple automatic conversion?

flammie commented 2 years ago

I didn't hear anything so I put gt_SHARED_smi snippets from core to specific langs for now, it mostly concerns builds with --enable-apertium so it shouldn't break too much also it would not have been working at all before for languages that did not have smi in configure.ac anyways.

snomos commented 2 years ago

Seems good. I'll close.