Closed snomos closed 9 months ago
This works on my machine, at least with the minimal ./autogen.sh && ./configure && make
…
16 rules cannot be skipped by index.
CP korp.cg3
CG3COMP korp.bin
…
That doesn't mean the bug is fixed, as it doesn't work in this environment as early as 8 hours ago.
Ok, found the bug. The issue is that korp.cg3
contains the following:
INCLUDE functions.cg3 ;
Now, as long as functions.cg3
is also copied from giella-shared
, this works fine - the file functions.cg3
is found in the build directory, and gets included as it should.
But when functions.cg3
is found locally AND you build out of source (VPATH builds), THEN functions.cg3
is NOT found - only the compiled functions.bin
. VPATH / out-of-source builds are what is used by most CI systems, including both Tino's and ours, thus you get fails.
The easiest solution is to change the include statement to the following:
INCLUDE functions.bin ;
But that would then require a rebuild every time korp.cg3
or functions.cg3
are changed. This does not go well with the cg3 developers, who are used to be able to run their grammars without make-ing things, as vislcg3 parses the source files on the fly.
I would still opt for this solution - these files are rarely changed, so the annoynce level should not be very high.
Comments, @Trondtr ?
There are two issues here:
Fixed in https://github.com/giellalt/lang-fkv/commit/eb37e2dbba327f4286f33814196cd3da43e36718 by adding korp.cg3
to the source tree in git, instead of copying from shared-smi
at build time.
This breaks the build.