giellalt / lang-sma

Finite state and Constraint Grammar based analysers and proofing tools, and language resources for the Southern Sami language
https://giellalt.uit.no
GNU General Public License v3.0
2 stars 3 forks source link

Test fail: ../../../src/fst/lexicon.tmp.lexc not found #19

Closed TinoDidriksen closed 10 months ago

TinoDidriksen commented 10 months ago

Missing .generated/ ?

make[5]: Entering directory '/build/giella-sma-0.2.0+g12579~6e9e3aa3-1~sid1/test/src/morphology'
./tag_test.sh: line 23: ../../../src/fst/lexicon.tmp.lexc: No such file or directory
sed: can't read ../../../src/fst/lexicon.tmp.lexc: No such file or directory
PASS: tag_test.sh
There were problem lemmas. Details in:
* missing_adjectives_lemmas.hfst.txt    
* generated_missing_adjectives_lemmas.hfst.txt
* analysed_missing_adjectives_lemmas.hfst.txt
hfst - FAIL
FAIL: generate-adjective-lemmas.sh

*** Warning: Source file ./../../../src/fst/stems/adpositions.lexc not found.

SKIP: generate-adpos-lemmas.sh

*** Warning: Source file ./../../../src/fst/stems/adverbs.lexc not found.

SKIP: generate-adverb-lemmas.sh
There were problem lemmas. Details in:
* missing_nouns_lemmas.hfst.txt    
* generated_missing_nouns_lemmas.hfst.txt
* analysed_missing_nouns_lemmas.hfst.txt
hfst - FAIL
FAIL: generate-noun-lemmas.sh

*** Warning: Source file(s) ./../../../src/fst/generated_files/smi-sma-propernouns.lexc not found.

SKIP: generate-propernoun-lemmas.sh
hfst - PASS
PASS: generate-verb-lemmas.sh
===================================
2 of 4 tests failed
(3 tests were not run)
Please report to feedback@divvun.no
===================================
make[5]: Leaving directory '/build/giella-sma-0.2.0+g12579~6e9e3aa3-1~sid1/test/src/morphology'
flammie commented 10 months ago

not sure what lexicon.tmp.lexc was, in practice make is not guaranteed to keep intermediate targets in any case maybe lexicon.lexc should be better reference? Others are still missing morphology in the path.

snomos commented 10 months ago

lexicon.tmp.lexc used to be the temporary lexc file created by concatenating all lexc files into one. It is/was used as the source for tag testing to ensure that we extract tags based on all the lexc sources, so that we don't miss anything.

The .tmp. in the filename is just to indicate to any bypassers that it is indeed a temporary file, but name and location does not matter beyond what is most practical.

TinoDidriksen commented 10 months ago

That fixed running the tests, but tests still fail. My build is in agreement with the https://github.com/giellalt/lang-sma/runs/20998409882 results.

TinoDidriksen commented 10 months ago

Ignored tests for now.