giellalt / lang-sme

Finite state and Constraint Grammar based analysers and proofing tools, and language resources for the Northern Sami language
https://giellalt.uit.no
GNU General Public License v3.0
6 stars 1 forks source link

gramcheck-test.py -c VS echo #34

Open duomdaamaendra opened 2 years ago

duomdaamaendra commented 2 years ago

these often give different analyses, for ex. of these clauses:

A: Test 102/484: Dát gáržžida plánekeahtes huksema mii dál dáhpáhuvvá viiddis sierralobi mieđihemiid vuođul, ja mat oktiibuot dagahit stuora ja viiddis sisabahkkemiid sámi guovlluin ja nu maiddái dagaha ahte meahci adnu rievdaduvvo.

[102/484][FAIL fp2] : (, ()) => viiddis:[viiddes] (typo)

B: Test 244/484: Čoahkkinjoiheaddji gohčču jogo daid áirasiid guđet vuostaldit eavttuhusa, dahje sin guđet dorjot eavttuhusa, čuožžilit.

[244/484][FAIL fp1] Čoahkkinjoiheaddji:Čoahkkinjođiheaddji (, ()) => Čoahkkinjoiheaddji:[čoahkkinjođiheaddji] (typo)

the latter seems to be somewhat related to "semi letters" - I often se words with initial Á get FP and get suggestion with á

duomdaamaendra commented 2 years ago

which one should you trust?

duomdaamaendra commented 2 years ago

hihi - "semi letters". I meant "sámi letters"

albbas commented 2 years ago

Test 102/484: Dát gáržžida plánekeahtes huksema mii dál dáhpáhuvvá viiddis sierralobi mieđihemiid vuođul, ja mat oktiibuot dagahit stuora ja viiddis sisabahkkemiid sámi guovlluin ja nu maiddái dagaha ahte meahci adnu rievdaduvvo.

[102/484][FAIL fp2] : (, ()) => viiddis:[viiddes] (typo)

When running the same test, using the nightly gramchecker (/usr/share/voikko/4/se.zcheck on my linux system), viiddis is not marked as an error.

Test 244/484: Čoahkkinjoiheaddji gohčču jogo daid áirasiid guđet vuostaldit eavttuhusa, dahje sin guđet dorjot eavttuhusa, čuožžilit.

[244/484][FAIL fp1] Čoahkkinjoiheaddji:Čoahkkinjođiheaddji (, ()) => Čoahkkinjoiheaddji:[čoahkkinjođiheaddji] (typo)

Here the error is in gramchecker-test.py

albbas commented 2 years ago

Test 244/484: Čoahkkinjoiheaddji gohčču jogo daid áirasiid guđet vuostaldit eavttuhusa, dahje sin guđet dorjot eavttuhusa, čuožžilit. [244/484][FAIL fp1] Čoahkkinjoiheaddji:Čoahkkinjođiheaddji (, ()) => Čoahkkinjoiheaddji:[čoahkkinjođiheaddji] (typo)

Here the error is in gramchecker-test.py

This part of the issue should be fixed in fc36b81 in giella-core.

snomos commented 2 years ago

This part of the issue should be fixed in fc36b81 in giella-core.

I have commented it here: https://github.com/giellalt/giella-core/commit/fc36b81f427b71599a1ef6133fb265d06c806bf4#commitcomment-60562322. Not sure whether this is the correct solution.

snomos commented 10 months ago

What is the status of this issue, @albbas ?