search

giffyglyph / foundry-5e-monster-maker

A D&D 5e monster maker module for the Foundry VTT. Build new monsters with level-appropriate, balanced stats in seconds.
30 stars 17 forks source link

Damage only actions not sending properly to chat #29

Closed Tabletop-RPG-Music closed 3 years ago

Tabletop-RPG-Music commented 3 years ago

If you make an action that is just damage (without an attack roll / saving throw), it just sends the name of the action to chat but not the damage. (Not sure if there's another way to make a macro for damage?)

Tabletop-RPG-Music commented 3 years ago

I think this might be a compatibility issue with midi-qol

giffyglyph commented 3 years ago

Looks like this is a midi-qol compatibility issue. The problem stems from midi-qol/utils.js:

export function itemHasDamage(item) {
    return item?.data.data.actionType !== "" && item?.hasDamage;
}

In FMM, damage can be set when no actionType is specified. Mqol is being too zealous in its checking here. Have now added the "utility" attack type to support damage-only prompts.

Tabletop-RPG-Music commented 3 years ago

Brilliant, thanks

giffyglyph commented 3 years ago

Fixed in v1.0.0. Can now select "utility" action type in scaling actions.

Tabletop-RPG-Music commented 3 years ago

Thanks for this.

It might be something that needs to be changed by the midi-qol developer rather than on your end, but I've noticed that with this latest update, midi-qol isn't applying any damage rolls, regardless of whether they're Utility or part of an attack roll / saving throw.

For example, clicking the damage button rolls the dice (if you have dice-so-nice installed) but doesn't show up any results. image

No pressure to fix this as I know it's probably a niche use case (I just love both modules and would love for them to work together)