search

giffyglyph / foundry-5e-monster-maker

A D&D 5e monster maker module for the Foundry VTT. Build new monsters with level-appropriate, balanced stats in seconds.
30 stars 17 forks source link

Incompatibility with MIDIQoL or ALL Automatic Saves #72

Open Rentty23 opened 2 years ago

Rentty23 commented 2 years ago

Miqol's automation of casting spells in area does not work when the MOD is on, the automatic save roll and damage are not applied.

As everyone knows, MIDIQoL is literally the most common thing in the foundry. Maybe you interesting to see this.

Rentty23 commented 2 years ago

image

Rentty23 commented 2 years ago

I just realized that this problem is happening with all saves made automatically, by any mod or macro.

Rentty23 commented 2 years ago

image

Rentty23 commented 2 years ago

it's as if the actors don't have the characteristics to roll, probably a problem in the variable used.

ra2phoenix commented 2 years ago

You can copy the changes from the PR I submitted in your local copy to fix this issue for the moment. I tested with Better Rolls but it should also fix the issue for Midi.

Rentty23 commented 2 years ago

WORKS FINE! THANKS FOR YOU TIME!

franckflo commented 2 years ago

It seems the automated saving throws are still not working as of September 2022. Was the change ever implemented in a new version? I tested with the saves implemented by Let me Roll That You and the Token Action HUD: Neither seem to work.

ra2phoenix commented 2 years ago

It was not, and the GMM 2 module is from what I hear completely nonfunctional in Foundry v10. I've started using the GMM 3 rules to build monsters manually in the normal sheets until the webapp is finished.

On Mon, Sep 12, 2022 at 4:28 AM franckflo @.***> wrote:

It seems the automated saving throws are still not working as of September

  1. Was the change ever implemented in a new version? I tested with the saves implemented by Let me Roll That You and the Token Action HUD: Neither seem to work.

— Reply to this email directly, view it on GitHub https://github.com/giffyglyph/foundry-5e-monster-maker/issues/72#issuecomment-1243602927, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKW7RE4LV27G3DNWTALFDCDV54HXLANCNFSM5TSOKYMA . You are receiving this because you commented.Message ID: @.***>

Skyl3lazer commented 1 year ago

As a note to the people in this thread, I've updated this module to GGMMv3, Foundry v10, and dnd5e 2.1.5+ on this fork. This includes more integration for midi and other similar automation.

https://github.com/Skyl3lazer/giffyglyph-monster-maker-continued

franckflo commented 1 year ago

Thanks!