search

giflw / remark-java

Remark is a HTML to Markdown library forked from https://bitbucket.org/OverZealous/remark (mercurial repository)
Other
26 stars 32 forks source link

Unescape dash after bold element #3

Closed pmendelski closed 6 years ago

pmendelski commented 7 years ago

Hi, thanks for this library. I had problems with a dash character after a bold element:

input:
<b>bold</b> - normal
output:
**bold** \- normal

I wanted to have the dash unescaped. Hence the PR.

input:
<b>bold</b> - normal
output:
**bold** - normal

Please let me know if it was an expected behavior.

P.S. BTW, build.gradle is a bit out of date. It's not compatible with gradle >=v3

pmendelski commented 7 years ago

Travis build is red :( Apparently, it thinks it's a ruby project:

No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)
giflw commented 6 years ago

@pmendelski Sorry for take too long to respond. I was away from this project, and didn't noticed this PR. I've tried to run travis, but didn't worked wel. I've merged anyway, as it seems a bug fix to me. Thanks!

giflw commented 6 years ago

I don't know why travis wasn't building the PR, but I've noticed that develop wasn't fully merged with master. In master gradle was replaced by maven.