search

giftig / flippy

A feature switching application which can also be used as a library for scala applications
MIT License
3 stars 3 forks source link

Add unit tests for redis backend #29

Closed giftig closed 7 years ago

giftig commented 7 years ago

...in addition to the integration tests.

giftig commented 7 years ago

This is going to be a pain because of the inability to extend / stub RedisClient. Might need to wrap it in a class to actually be able to mock it.

giftig commented 7 years ago

Having to add wrapping code for the RedisClient to test it adds unjustified complexity which will only increase the likelihood of it breaking, I think, and the github page for the redis library makes it clear it can't be mocked.