search

gigabit101 / Shrink

GNU Lesser General Public License v3.0
10 stars 11 forks source link

[Bug]: Entity does not have size set at chunk load #111

Open Linguardium opened 1 month ago

Linguardium commented 1 month ago

Describe the bug

Entity does not have size set at chunk load

Steps to reproduce

find a mob that is larger than 1x1 shrink it to the 1x1 size put it in a hole that is 1x1 unload chunk reload chunk notice the mob has moved outside of the hole due to loading in with size > 1x1 and later size being reset.

Expected behaviour

size should persist at entity load time and entities should not be pushed out of spaces that their shrunk size fits in

Screenshots

image image image

Version

2.0.0.43

Minecraft Version

1.21.1

ModLoader Version

neoforge 21.1.59

Additional Information

using Craftoria modpack

gigabit101 commented 1 month ago

Does this happen on vanilla mobs? I assume that the modded mobs are not saving their entity size (This is a vanilla thing now so not much I can do about it)

Linguardium commented 1 month ago

I checked the occultism code and they do call super.readAdditionalSaveData to TameableAnimal which calls super all the way up to Entity. Since its a vanilla thing and they use the Vanilla code for attribute containers, this mod should be having no issues with them

gigabit101 commented 1 week ago

I don't really have a lot of control over this since moving to the vanilla entity size attribute, will see if there is something I can do