search

gigabytedevelopers / FireFiles

Powerful Android File Manager for everything that runs on Android OS (Android TV, Android Watch, Mobile, etc)
Apache License 2.0
57 stars 17 forks source link

Latest release (v2.3.7) contains ads/tracking even in FDroid build #3

Closed IzzySoft closed 6 years ago

IzzySoft commented 6 years ago

I'm shocked! And I hope it is all just a simple mistake. But according to my library scanner, even FireFiles-Fdroid-release-2.3.7.apk contains:

None of those were present in v2.3.6 – and honestly, with those ingredients it cannot seriously be called *Fdroid* as those elements are not acceptable by F-Droid. Could you please check what went wrong there? Meanwhile, I have to raise the AntiFeatures (Tracking, NonFreeDep) in my repo.

gigabytedevelopersinc commented 6 years ago

Whoa! That must be some kinda silly mistake from our part! Please pardon us and give us today to fix this! @enwokoma, get in here and fix this, u caused this problem!

On Feb 14, 2018 00:19, "Izzy" notifications@github.com wrote:

I'm shocked! And I hope it is all just a simple mistake. But according to my library scanner, even FireFiles-Fdroid-release-2.3.7.apk contains:

  • GMS
  • Firebase
  • Firebase Analytics
  • Crashlytics

None of those were present in v2.3.6 – and honestly, with those ingredients it cannot seriously be called Fdroid as those elements are not acceptable by F-Droid. Could you please check what went wrong there? Meanwhile, I have to raise the AntiFeatures (Tracking, NonFreeDep) in my repo.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gigabytedevelopers/FireFiles/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AY_wp4poWFy0ZCS_UKIQt1QwZHD2Gk6Yks5tUhhkgaJpZM4SEjrB .

IzzySoft commented 6 years ago

Glad to read it wasn't intended that way – and of course it doesn't solve by just winking your magic wand. Thanks for taking care!

enwokoma commented 6 years ago

Good day! Been busy since. Returned now and just saw this! Am so so sorry! This issue emerged once again because of my carelessness! I would make some commits before the end of today!

Thanks @IzzySoft for spotting this one out, it wasn't intentional!

IzzySoft commented 6 years ago

@enwokoma it was my scanner spotting it, throwing me a warning about missing AntiFeatures. Same scanner will notify me about obsolete AntiFeatures as soon as they are gone :wink:

Btw: Will you keep the *Fdroid* in the name of the "free" APK? As your releases now carry more than one .apk I'd need something to tell my updater to pick. I've currently set it on that term, so if you keep this all is fine here. If not, please let me know.

enwokoma commented 6 years ago

I have made commits referencing this issue and I can acknowledge from my end that this issue has been fixed!,

2 has also been fixed. Please confirm from your end too that it has been fixed as am closing both issues by tomorrow!

Thanks!

IzzySoft commented 6 years ago

I can confirm this issue here seems to be solved – my scanner no longer detects those libraries, and thus I also removed the AntiFeature-tags (changes are just being pushed out right now).

I have no time for an in-depth check of #2 – so I just believe you if you say it's solved. Thanks for the fast fixes! And are you keeping the term "Fdroid" in the "free APK name"? Because as soon as you switch that again, my auto-updater would no longer be able to catch, so we should agree on something :wink:

enwokoma commented 6 years ago

Yes! We would be keeping the term "Fdroid" for a more efficient identification because, we now have a lot of platforms (Amazon, Google Play, Fdroid, plus our Pro version). So, yes, the "Fdroid" term stays as we don't want a situation when things get complicated trying to identify which apk is for F-Droid, Amazon, Free, Pro or Google Play release!

PS: on the releases page, the apk without the term Fdroid attached to it is just the regular Google Play release which contains the GMS, Firebase, Firebase Analytics and Crashlytics libraries!

IzzySoft commented 6 years ago

Thanks Emmanuel! So I figured that right. Considering this issue solved then, and close it.

See you later :wink: