search

gigaherz / Enderthing

Ender-chests evolved
https://www.curseforge.com/minecraft/mc-mods/enderthing
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

[1.9.4] Enderthing Chest Crash when using RFTools Builder #10

Closed Mohron closed 8 years ago

Mohron commented 8 years ago

Version: enderthing-1.9.4-0.6.7.jar RFTools: rftools-1.9.4-4.63.jar, mcjtylib-1.9.4-1.9.1.jar

There is a crash I've been getting time from time when using an enderthing Ender Key Chest with the RFTools builder with quarry shape card.

RFTools Issue

Crash Log 1 Crash Log 2 Crash Log 3

gigaherz commented 8 years ago

Hmf if this happens with the 0.6.7 version, that means the backport I released today, is broken. (I wish you had posted this just a few hours ago. XD)

It also means I have no idea how it can still happen. Really sucks that it cna't detect who else was involved on the Concurrent Modification :/

gigaherz commented 8 years ago

I can only think of two ways in which this could possibly happen:

  1. A block is being loaded as a consequence of "markDirty()", which cuases this TE to call addWeakListener()
  2. A block is pushing items in its onNeighborChange, which was initiated by the TE's markDirty()

I have no idea how to fix that in a clean way.

gigaherz commented 8 years ago

Could you try 0.6.8 and tell me if the issue stops happening?

gigaherz commented 8 years ago

It has been 4 days and no reply, closing. If this still happens, just comment and I will reopen.