gigaherz / EyesInTheDarkness

A small spooky mod for the MMD SPookyJam 2018
https://www.curseforge.com/minecraft/mc-mods/eyes-in-the-darkness
BSD 3-Clause "New" or "Revised" License
4 stars 6 forks source link

[Suggestion] Eye Emissives #28

Open PlayfulPiano opened 9 months ago

PlayfulPiano commented 9 months ago

From what I can tell currently, the eyes are sometimes extremely hard to see, especially if you're using other visual overhauls (e.g. shaders). Making it so the eyes themselves have a bit of an emissive effect could help with pointing them out. Plus it fits with the idea of "glowing eyes in the dark".

gigaherz commented 9 months ago

Hi what mc version and mod version are you using? Because I fixed the eyes rendering recently but only for 1.20.1+. I didn't get around to backporting that fix.

PlayfulPiano commented 9 months ago

I'm using 1.3.10 for 1.20.1. They do render, it's just that it's extremely hard to spot one and relies heavily on sound cues.

gigaherz commented 9 months ago

try 1.3.9? 1.3.10 was supposed to make them MORE visible but maybe something went wrong that I didn't consider when applying the fix.

PlayfulPiano commented 9 months ago

image 1.3.10

image 1.3.9

yeah 1.3.10 is def better but it's still like, hard to see dependent on its background.

gigaherz commented 9 months ago

Yeah not much I can do about that, then. In 1.3.10 I switched to using the eyes render type, the same one used by invisible spiders. Before that, I already set the eyes to be fully self-lit ("emissive"), so right now they are about as bright as I can make them using vanilla code, so far as I know.

PlayfulPiano commented 9 months ago

For example this is what I meant by emissives. Giving the eyes themselves a bit of a glow that's pretty visible. Might need resource pack parity is the only problem. image

gigaherz commented 9 months ago

For example this is what I meant by emissives. Giving the eyes themselves a bit of a glow that's pretty visible. image

I assume this is a feature of the shader mod, either hardcoded for specific textures, or using custom metadata for those textures. If it's the latter, you can add that metadata yourself in some resource pack that makes the eyes emissive. Honestly, I don't particularly care about shader mods, specially optifine, so if you (or someone else) figures out how this works and wants to contribute the necessary metadata then I can look into merging that into the mod, otherwise it's easy to have as a resource pack.

PlayfulPiano commented 9 months ago

iirc there are ways for mods to auto-load resource packs built in so it might work out, just would have to mention that emissive effects require some form of mod support (optifine, ETF, iris).

gigaherz commented 9 months ago

iirc there are ways for mods to auto-load resource packs built in so it might work out, just would have to mention that emissive effects require some form of mod support (optifine, ETF, iris).

Mods themselves are resource packs, that's how we add textures and such, we have an assets folder in the .jar that contains resource pack files.

PlayfulPiano commented 9 months ago

For example this is what I meant by emissives. Giving the eyes themselves a bit of a glow that's pretty visible. image

I assume this is a feature of the shader mod, either hardcoded for specific textures, or using custom metadata for those textures. If it's the latter, you can add that metadata yourself in some resource pack that makes the eyes emissive. Honestly, I don't particularly care about shader mods, specially optifine, so if you (or someone else) figures out how this works and wants to contribute the necessary metadata then I can look into merging that into the mod, otherwise it's easy to have as a resource pack.

I believe in this case it's from the Entity Model Features mod, which is based on optifine's implementation I believe.

PlayfulPiano commented 9 months ago

Entity Texture Features* my bad

PlayfulPiano commented 9 months ago

image I'm unsure if under this description the eye texture would qualify or not.

PlayfulPiano commented 9 months ago

Oh, actually it does seem like there are emissives. image

Wait, do the eyes not render dependent on sky light level? I was mainly noticing my issue while in the nether for example.

gigaherz commented 9 months ago

Ah, yes, I forgot, the eyes become transparent when they are lit. More block/sun light = more transparent. At full (level 15) light they are fully invisible.

PlayfulPiano commented 9 months ago

Does the transparency affect whether they can attack or not?

It might be worthwhile then to change it so they're not fully transparent within certain dimensions at least, like the nether or end, considering hostiles still spawn at those higher light levels.

gigaherz commented 9 months ago

Yes, fully invisible ones don't attack. And yeah good idea, I should make a dimension filter so that the light level is only used in dimensions with a sun...

PlayfulPiano commented 9 months ago

Yeah, that would likely fix my issues with visibility as well.