Few additions - Githubissues

gigaherz / Guidebook

Minecraft book API and library

https://www.curseforge.com/minecraft/mc-mods/guidebook

Other

31 stars 16 forks source link

Few additions #76

Closed TomaszewskiPatryk closed 3 years ago

TomaszewskiPatryk commented 6 years ago

These are few changes that I decided to add to guidebook. Main additions are:

New element - dynamic, which allows to display data based on user settings
More conditions and composite conditions
Upgrades for stack element
Link support for images and stacks

There is also a wiki already prepared to update this one after merge.

gigaherz commented 6 years ago

Sorry that I'm taking a long time to review. Life's a bit annoying right now and my head isn't in its best place. Your chances are extensive and not all things are the way I wanted things to move toward, so I have to give it some thought. The last thing I want is to merge this, and then decide it's not how I want it and rewrite your changes. I know how awful that would probably make you feel.

TomaszewskiPatryk commented 5 years ago

No problem, take all the time you want. And I know how important it is to check if everything fits and works with each other, especially when my code might not be the cleanest...

TomaszewskiPatryk commented 5 years ago

So... I'm guessing this won't be merged?