gigaherz / Guidebook

Minecraft book API and library
https://www.curseforge.com/minecraft/mc-mods/guidebook
Other
31 stars 16 forks source link

Latest Version (Guidebook-1.12.2-2.9.1.jar) Breaks GiveOnFirstJoin #85

Closed jaxmacky closed 5 years ago

jaxmacky commented 5 years ago

Guidebook-1.12.2-2.9.1.jar forge-14.23.5.2838 MC 1.12.2

Latest version (Guidebook-1.12.2-2.9.1.jar) breaks GiveOnFirstJoin; no beginning book in inventory on first join.

Downgrading to Guidebook-1.12.2-2.8.3.jar fixes the issue.

gigaherz commented 5 years ago

I'll take a look, thanks for the report!

gigaherz commented 5 years ago

I can't reproduce in my development environment.

I set it to give me a couple books in the config, image

and they appeared in my inventory justfine after joining the world again, image

Can you provide any more detail? Are there any errors in the log? Does it only happen in a dedicated server?

jaxmacky commented 5 years ago

Is that in game config new with (Guidebook-1.12.2-2.9.1.jar) ?

gigaherz commented 5 years ago

Yes, although I had it in my in-development code for many months before the latest release, so it's not "new" to me. XD

gigaherz commented 5 years ago

Oh this reminds me, I believe Forge doesn't delete old entries when configs are loaded, so there's a change you might have config values that are no longer relevant.

The config file that I had after editing with the GUI was:

# Configuration file

general {
    # Use -1 for same as GUI scale, 0 for auto, 1+ for small/medium/large
    # Min: -1
    # Max: 10
    I:bookGUIScale=0

    # Keep at false to use integral scaling, which makes the font pixels evently scaled. If set to true, the books will fill the screen space, even if the font becomes wonky.
    B:flexibleScale=false

    # List of books to give to the player when they join. Applied retroactively to existing players if a new book is added to the list.
    S:giveOnFirstJoin <
        gbook:book.xml
        gbook:bug.xml
     >
}
jaxmacky commented 5 years ago

I will test further, and report back. Been a long day already, so might be until tomorrow. I'll try and delete the config, let it auto generate, and add the book after. I do thank you for the quick replies.

jaxmacky commented 5 years ago

Success!

-Removed Previous Config -Updated Mod -Start Pack/Generate New Config -Add Book.xml to New Config -Restart Pack -Get Book in Hand!

Thank You!

gigaherz commented 5 years ago

Glad to hear. :)