search

gigaherz / JsonThings

Data-driven minecraft
https://www.curseforge.com/minecraft/mc-mods/json-things
Other
22 stars 6 forks source link

[1.20] Startup crash #24

Closed MelanX closed 1 year ago

MelanX commented 1 year ago

MC 1.20.1 Forge 47.1.0 Json Things 0.8.8

latest.log + crash report: https://gist.github.com/MelanX/6bd0ec196e5fa74ea556a1b4c7962ce4

How to reproduce?

  1. Create a new Forge instance (not in dev env)
  2. Install Json Things
  3. Start game
  4. Wait for it

This only happens in 1.20.1. The field the stacktracing is referencing to is LOGGER. Probably something related to https://github.com/gigaherz/JsonThings/blob/master/src/main/java/dev/gigaherz/jsonthings/things/parsers/ThingParser.java#L38

gigaherz commented 1 year ago

No it's this one. https://github.com/gigaherz/JsonThings/blob/master/src/main/java/dev/gigaherz/jsonthings/things/parsers/SoundEventParser.java#L26 The two there. Oops!

gigaherz commented 1 year ago

It seems like it's a glitch in the reobf process, which doesn't realize static fields shouldn't inherit reobf renames from the parent class. I have fixed it either way. Will release in a few hours when I can finish another thing.

gigaherz commented 1 year ago

Should be fixed in 0.9.0