search

gigaherz / JsonThings

Data-driven minecraft
https://www.curseforge.com/minecraft/mc-mods/json-things
Other
23 stars 5 forks source link

Warning while loading mods #25

Closed MelanX closed 1 year ago

MelanX commented 1 year ago

MC 1.20.1 Forge 47.1.43 JsonThings 0.9.0

How to reproduce

  1. Create a new instance with given versions
  2. Start game
  3. See this: image

Here's my latest.log: https://gist.github.com/MelanX/fb685dfe0657b541ec7bf01a7697bda7

I know, it's not critical, I still can play the game when pressing on the bottom button.

gigaherz commented 1 year ago

Hmm I guess it may be because the pack_format was 9 instead of 15? but it doesn't show up in dev so no idea.

MelanX commented 1 year ago

I changed the pack formats at each value to 15, it still shows this screen. As additional info: It lists all installed mods as "failed to load a valid ResourcePackInfo" when Json Things is installed. Not sure if this information is helpful at all.

gigaherz commented 1 year ago

o_O I'll look into it, maybe the warning is my fault somehow...

gigaherz commented 1 year ago

Yep was my fault. The code I had for loading ThingPacks from mod jars was outdated and caused the issue. Bringing it to parity with forge's logic that does the same for resource packs fixed it. 0.9.1 is up on CurseForge waiting for review.

gigaherz commented 1 year ago

Ah right, CF is broken, approval may take a bit longer.

MelanX commented 1 year ago

Awesome, thank you