gigaherz / JsonThings

Data-driven minecraft
https://www.curseforge.com/minecraft/mc-mods/json-things
Other
22 stars 6 forks source link

Can't specify a destroy_time that is smaller than 1.0 #3

Closed TheInfine closed 2 years ago

TheInfine commented 2 years ago

Setting a destroy_time that is smaller than 1.0 makes the block break instantly. This means that the fastest valid destroy_time is 1.0 which isn't fast enough in my case. This also affects sandwood leaves in the Sandwood example.

Minecraft: 1.18.1 Forge: 39.0.79 Json Things: 0.2.1

gigaherz commented 2 years ago

Nice catch. I'm not at home right now so will fix asap.

TheInfine commented 2 years ago

Same problem happens with explosion_resistance too.

gigaherz commented 2 years ago

Thanks. I probably misinterpreted what the value range was.

gigaherz commented 2 years ago

I'm home now, and I looked at it. I did indeed use the wrong types for this. I used integers, where it should be floating-point values. Preparing fixed versions for 1.16.5, 1.17.1 and 1.18.1

gigaherz commented 2 years ago

Fixed as of 1.16.5-0.1.3, 1.17.1-0.1.3, and 1.18.1-0.2.2