gigaherz / Survivalist

Spicing up the early game, without making it tedious
https://www.curseforge.com/minecraft/mc-mods/survivalist
BSD 3-Clause "New" or "Revised" License
18 stars 11 forks source link

Scrapping feature checks Extra Utilites 2 Quantum Quarry #28

Open Biochao opened 7 years ago

Biochao commented 7 years ago

While running an Extra Utilites 2 Quantum Quarry the log was reporting this over and over:

[Server thread/DEBUG] [survivalist/]: Item broke (0xitem.pickaxeDiamond@1) and the player got 1xitem.stick@0 in return!

[Server thread/DEBUG] [survivalist/]: Item broke (0xitem.pickaxeDiamond@1) and the player got 1xitem.diamond@0 in return!

The sticks and diamonds were going into the storage. Not sure if happens for all fake players or just how the Quantum Quarry simulates mining.

gigaherz commented 7 years ago

Weird, I'll have to check that. It's the first report of this kind that I get, so it can't be so common... :/

gigaherz commented 7 years ago

Annoyingly, I can't run extrautils2 in my development environment (it just crashes), so I can't debug this.

gigaherz commented 6 years ago

Oh wow it has been a long time...

I have looked at the extrautils2 source code, and it seems the quarry does actually use a diamond pickaxe internally, using a "fake player" to do the mining. This means that if you use an enchantment book that contains Scrapping in it, this will happen.

The only way I can work around that, is by "blocking" XUFakePlayer instances from triggering the scrapping, which may or may not affect other XU2 machines, which wouldn't be ideal if it does.