search

gigaherz / Survivalist

Spicing up the early game, without making it tedious
https://www.curseforge.com/minecraft/mc-mods/survivalist
BSD 3-Clause "New" or "Revised" License
18 stars 11 forks source link

add option to disable scrapping enchantment #72

Closed majijn closed 6 years ago

majijn commented 6 years ago

I set every single option under "scraping" as false and i am still getting the enchantment , it stops me from seeing if I'm going to get other enchants (for example fortune, which is the one I am currently unable to get) it may even be messing with the vanilla multiple enchantments algorithm , because I should have already gotten a fortune book from my AFK fish farm (ive left it on overnight for three nights, I dont know how I haven't gotten any level of fortune, given how ive gotten several silk touch weapons and tools

I wouldnt mind being able to have the option to have it be a treasure enchantment rather than a normal one, as it's mostly the fact that it's so ubiquitous when enchanting things through the table rather than an anvil that's proving so troublesome to me

gigaherz commented 6 years ago

Oops, when scraping is disabled, it would still have the enchantment itself, just it would do nothing.

I have now changed it so that the enchantment keeps existing (in case existing items use it), but if it's disabled, it can't be applied to anything (meaning it won't show on the enchantment table, and the books won't work on the anvil... except in creative mode).

I have also added a "IsTreasureEnchantment" option, since I thought it's a good idea.

gigaherz commented 6 years ago

I have built and uploaded v2.1.5 (awaiting review), which I hope shouldn't have this issue. Feel free to comment here if it still happens.