search

gigalixir / gigalixir-cli

MIT License
52 stars 45 forks source link

Gigalixir Broke Unrelated Apps That I Develop #19

Closed JEG2 closed 6 years ago

JEG2 commented 6 years ago

After playing with Gigalixir recently, I was surprised to find that some other applications that I develop no longer work on my laptop. I lost a few hours tracking down the cause. It boils down to an entry that Gigalixir's tools added to my .netrc file for localhost. Here's the code that performs that change:

https://github.com/gigalixir/gigalixir-cli/blob/master/gigalixir/netrc.py#L37

This modification seems unsafe. It adds—or overrides in some cases—authorization for all loopback requests that honor my .netrc file. That's a pretty sweeping change.

jesseshieh commented 6 years ago

Thanks for the bug report @JEG2. Merging a fix now.

jesseshieh commented 6 years ago

@JEG2 fix is merged and released in v1.0.5. If you want the fix, upgrade your cli with sudo pip install -U gigalixir --ignore-installed six