search

gigalixir / gigalixir-cli

MIT License
52 stars 45 forks source link

gigalixir login fails with "Unknown platform: msys_nt-10.0" #28

Closed Zyclotrop-j closed 5 years ago

Zyclotrop-j commented 5 years ago

Environment

pip 19.0.1 from C:\Python27\lib\site-packages\pip (python 2.7) Python 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:42:59) [MSC v.1500 32 bit (Intel)] on win32

How to reproduce

gigalixir login

(or gigalixir version or gigalixir logs or ...)

Expected result

login promt should show

Actual result

Crashes with exception Exception: Unknown platform: msys_nt-10.0

Full stack trace:

gigalixir help
Traceback (most recent call last):
  File "c:\python27\lib\runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "c:\python27\lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "C:\Python27\Scripts\gigalixir.exe\__main__.py", line 9, in <module>
  File "c:\python27\lib\site-packages\click\core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "c:\python27\lib\site-packages\click\core.py", line 697, in main
    rv = self.invoke(ctx)
  File "c:\python27\lib\site-packages\click\core.py", line 1063, in invoke
    Command.invoke(self, ctx)
  File "c:\python27\lib\site-packages\click\core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\python27\lib\site-packages\click\core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "c:\python27\lib\site-packages\click\decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "c:\python27\lib\site-packages\gigalixir\__init__.py", line 231, in cli
    raise Exception("Unknown platform: %s" % PLATFORM)
Exception: Unknown platform: msys_nt-10.0

Most likely reason

Looking at https://github.com/gigalixir/gigalixir-cli/blob/334760952d058be40dfe1737cb0abf3f3604c307/gigalixir/__init__.py#L223, it looks like windows is not supported

jesseshieh commented 5 years ago

Hi, thanks for the issue. Unfortunately, it's true. Windows isn't currently supported. It's on our to-do list, but we don't have a timeline for it. We're happy to accept pull requests if you want to give it a shot!

DKhalil commented 5 years ago

Does it have any priority for you or is it on your nice-to-have list?

jesseshieh commented 5 years ago

Our priorities are determined by customer demand so if more people request windows support we will increase the priority. We tried to support it initially, but ran into some issues with netrc iirc. If anyone wants to take a stab at making authentication work, we would definitely work with you to implement it.

jesseshieh commented 5 years ago

Windows support is merged and released as 1.10 https://pypi.org/project/gigalixir/