search

gigalixir / gigalixir-cli

MIT License
52 stars 45 forks source link

Add ssh_cmd option to all ssh commands #54

Closed Anderssorby closed 4 years ago

Anderssorby commented 4 years ago

After a quick glance at the source I'm trying to add an option to change the default ssh-command ref #52. This is to give control in cases where the user wants a custom ssh command like kitty +kitten ssh. E.g. gigalixir ps:remote_shell --ssh_cmd "kitty +kitten ssh"

I haven't gotten the tests to run properly yet.

Maybe this should be added to the config so that you don't have to include it in every command.

jesseshieh commented 4 years ago

Thanks for doing this. This looks okay to me as long as the tests pass, but I wonder if ssh_opts is now no longer needed. What do you think? I'll try and run the tests when I get a chance.

Anderssorby commented 4 years ago

ssh_opts is sort of redundant now, but in terms of backward compatibility and intuitiveness I think it should stay.

jesseshieh commented 4 years ago

I just ran the tests and they all passed. Thanks for the pull request!

jesseshieh commented 4 years ago

Just released as 1.1.4 https://pypi.org/project/gigalixir/1.1.4/