Open rija opened 6 months ago
We need to evaluate the usage of DataCite REST API.
% curl https://api.test.datacite.org/dois/10.80027/100006 | jq '.[].attributes.url'
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 9221 0 9221 0 0 8204 0 --:--:-- 0:00:01 --:--:-- 8233
"http://gigadb.org/dataset/100006"
Hi @kencho51,
That was already suggested in #456
but this issue is independent of what API is used and is not specific to DataCite interactions We just need to get rid of the use of curl in the codebase. I think we have started doing that already, but there is still the code in AdminDatasetController.php. I believe that's the last instance, but we would need to confirm that.
the issue in the current code, is that the errors other than 422 are not being handled. Also why do you need to show the response message received (frontend)?
User story
Acceptance criteria
Additional Info
This is just for the code we write/maintain. There are some dependencies that currently may need their own specific HTTP client installed (e.g: Unleashed)
This is created out of reviewing PR #1728
Product Backlog Item Ready Checklist
Product Backlog Item Done Checklist