Feat: Code refactoring to separate upload status transition and notifications (e.g: email) in preparation for upcoming work on dataset status overhaul

[alli83]

Pull request for issue: #701

This is a pull request for the following functionalities:

separate the transition and notification concerning upload_status update. If the transition is not allowed, the model shouldn't be saved.

It's temporary, while waiting for a PR creating a dedicated service

How to test?

• Go to a dataset form
• try "UserStartedIncomplete" to "Submitted" or to "DataPending"
• Scroll down to Save
• changes should not been saved.

How have functionalities been implemented?

Any issues with implementation?

Any changes to automated tests?

Any changes to documentation?

Any technical debt repayment?

Any improvements to CI/CD pipeline?

[alli83]

next step (PR) will be to create a dedicated service for the "workflow" and email handling, followed by another PR to set up a more effective workflow.

[kencho51]

Hi @alli83,

question: I have tried to follow your How to test in my local dev environment, given the status is UserStartedIncomplete, when I changed to dataAvailableForReview and updated the values in Source, Tag and Photographer fields, the changes were saved as you can see below: So, I want to know whether the changes should be saved or not? chore: Rebase this PR with the gigascience/develop branch.

[alli83]

@kencho51 there was an error in the description. I updated it

[alli83]

I think it's related to a rewrite but maybe there was another intermediate issue. I'll look into it.